Merged
Conversation
MatthewDaggitt
approved these changes
Jul 30, 2025
Collaborator
|
Thanks @JacquesCarette! Was hoping to make the release of v2.3 now, but I guess we need to wait for @jamesmckinna's approval for this. |
Collaborator
|
Review incoming, but as a placeholder
Re: |
jamesmckinna
requested changes
Jul 31, 2025
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
See placeholder comment, plus module-level suggestion.
CHANGELOG comments to follow
Collaborator
|
I've only made |
4 tasks
4 tasks
Collaborator
|
Question: when/if this is merged into the |
Closed
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Collaborator
Author
|
If/when this gets merged, we'll have to cherry-pick it, somehow, back onto master and experimental. |
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
This was indeed anachronistic from 2.0 Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Collaborator
|
Will re-review in the morning! |
jamesmckinna
requested changes
Aug 1, 2025
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
Thanks very much again for this!
We're in the home strait...
- merge the two
Data.Fin.Propertiessections ofCHANGELOG - (possibly) fix names for
Data.Sum.Relation.Binary.Pointwiseeither in place, or else inCHANGELOG
Happy to do a final edit myself to fix these up!
jamesmckinna
reviewed
Aug 1, 2025
jamesmckinna
reviewed
Aug 1, 2025
Collaborator
|
@MatthewDaggitt @JacquesCarette thanks for all your efforts in helping sort out the mess I created. |
Collaborator
Author
|
I should be able to get to this today. |
Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com>
Collaborator
Author
|
Should be good to go now @jamesmckinna . |
jamesmckinna
approved these changes
Aug 1, 2025
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
Fantastic! Thanks so much for persevering... and now I hand back to @MatthewDaggitt
MatthewDaggitt
added a commit
that referenced
this pull request
Aug 2, 2025
* opposite of a `Ring` [clean version of pr #1900] (#1910) * punchOut preserves ordering (#1913) * Wellfounded proof for sum relations (#1920) * last revert undone by hand * Remove extra line in CHANGELOG * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md This was indeed anachronistic from 2.0 Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * resolve issues pointed out by James. * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * remove now obsolete comment * last mistake in CHANGELOG, hopefully fixed now. --------- Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> Co-authored-by: Nathan van Doorn <nvd1234@gmail.com> Co-authored-by: Alice Laroche <60161310+Seiryn21@users.noreply.github.com> Co-authored-by: matthewdaggitt <matthewdaggitt@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2025
* Add back accidentally removed lemmas (Issue2788 #2794)) * opposite of a `Ring` [clean version of pr #1900] (#1910) * punchOut preserves ordering (#1913) * Wellfounded proof for sum relations (#1920) * last revert undone by hand * Remove extra line in CHANGELOG * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md This was indeed anachronistic from 2.0 Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * resolve issues pointed out by James. * Update CHANGELOG.md Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> * remove now obsolete comment * last mistake in CHANGELOG, hopefully fixed now. --------- Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> Co-authored-by: Nathan van Doorn <nvd1234@gmail.com> Co-authored-by: Alice Laroche <60161310+Seiryn21@users.noreply.github.com> Co-authored-by: matthewdaggitt <matthewdaggitt@gmail.com> * Bring v2.3 release changes accross * Fix typo * Fix whitespace --------- Co-authored-by: Jacques Carette <carette@mcmaster.ca> Co-authored-by: jamesmckinna <31931406+jamesmckinna@users.noreply.github.com> Co-authored-by: Nathan van Doorn <nvd1234@gmail.com> Co-authored-by: Alice Laroche <60161310+Seiryn21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts back everything that was mistakenly reverted -- closes #2788